Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Switch PUI linting to biome #8317

Draft
wants to merge 32 commits into
base: master
Choose a base branch
from
Draft

WIP: Switch PUI linting to biome #8317

wants to merge 32 commits into from
+2,439 −2,337

Conversation

matmair
Copy link
Member

@matmair matmair commented Oct 19, 2024

Currently eslint and prettier are setup up (probably incorrectly as they do not seem to work) in pre-commt for PUI linting/formatting. This PR replaces both with biome, which is faster and does basically the same things and seems to work.

@matmair matmair added CI CI / unit testing ecosystem refactor labels Oct 19, 2024
@matmair matmair added this to the 0.17.0 milestone Oct 19, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 19, 2024 •
edited
Loading

✅ Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit 4af3473
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/67143e781d085100089b7f99
😎 Deploy Preview https://deploy-preview-8317--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 100 (no change from production)
Accessibility: 86 (no change from production)
Best Practices: 92 (no change from production)
SEO: 70 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov Codecov
Copy link

codecov bot commented Oct 19, 2024

Codecov Report

Attention: Patch coverage is 62.89157% with 154 lines in your changes missing coverage. Please review.

Project coverage is 84.31%. Comparing base (5f905aa) to head (4af3473).

Files with missing lines Patch % Lines
...end/src/components/importer/ImportDataSelector.tsx 0.00% 11 Missing ⚠️
...c/frontend/src/tables/part/ParametricPartTable.tsx 0.00% 6 Missing ⚠️
src/frontend/src/tables/bom/BomTable.tsx 70.58% 1 Missing and 4 partials ⚠️
.../frontend/src/tables/stock/TestStatisticsTable.tsx 0.00% 5 Missing ⚠️
...rontend/src/pages/part/pricing/BomPricingPanel.tsx 42.85% 0 Missing and 4 partials ⚠️
src/frontend/src/tables/InvenTreeTable.tsx 77.77% 3 Missing and 1 partial ⚠️
src/frontend/src/tables/build/BuildLineTable.tsx 0.00% 4 Missing ⚠️
...ontend/src/tables/part/PartPurchaseOrdersTable.tsx 0.00% 4 Missing ⚠️
src/frontend/src/tables/stock/StockItemTable.tsx 69.23% 0 Missing and 4 partials ⚠️
...frontend/src/components/nav/NotificationDrawer.tsx 0.00% 3 Missing ⚠️
... and 67 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8317      +/-   ##
==========================================
- Coverage   84.35%   84.31%   -0.05%     
==========================================
  Files        1165     1165              
  Lines       52845    52845              
  Branches     1931     1929       -2     
==========================================
- Hits        44577    44554      -23     
- Misses       7774     7815      +41     
+ Partials      494      476      -18
Flag Coverage Δ
pui 67.10% <62.89%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SchrodingersGat SchrodingersGat Awaiting requested review from SchrodingersGat SchrodingersGat will be requested when the pull request is marked ready for review SchrodingersGat is a code owner

Assignees
No one assigned
Labels
CI CI / unit testing ecosystem refactor
Projects
None yet
Milestone
0.17.0
Development

Successfully merging this pull request may close these issues.
1 participant
@matmair